tools icon indicating copy to clipboard operation
tools copied to clipboard

feat(rome_js_analyzer): add useAltText lint rule for JSX expression

Open b4s36t4 opened this issue 3 years ago • 2 comments

Summary

Closes #3298 following the document given for valid and in-valid conditions.

#3298

Test Plan

A lint rule to check for alt attribute in JSX for tags like input type='image', img, area.

b4s36t4 avatar Oct 08 '22 18:10 b4s36t4

Deploy Preview for docs-rometools failed.

Name Link
Latest commit 2014015b5624e29adce8cb67424b209eee28c5dc
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/634daa06b70bb9000befc44f

netlify[bot] avatar Oct 08 '22 18:10 netlify[bot]

@ematipico I have updated the code, please check it.

Note: as part of skipping cases including {...props} spread items existing cases mentioned in the doc will became valid. Please check the snapshots for more context.

b4s36t4 avatar Oct 17 '22 19:10 b4s36t4

Closing in favour of https://github.com/rome/tools/pull/3502

@b4s36t4 I opened a new PR with your commits. We want to have this rule merged before the release.

ematipico avatar Oct 26 '22 12:10 ematipico