tools icon indicating copy to clipboard operation
tools copied to clipboard

fix(rome_js_parser): permisive instantiation expression

Open IWANABETHATGUY opened this issue 2 years ago • 5 comments

Summary

  1. Part of https://github.com/rome/tools/issues/3147
  2. Related to https://github.com/microsoft/TypeScript/pull/48659

Test Plan

  1. CI should pass.
  2. New snapshot.

IWANABETHATGUY avatar Oct 07 '22 11:10 IWANABETHATGUY

Deploy Preview for docs-rometools ready!

Name Link
Latest commit f3b3447bd853ccabbce3b81a32fbd25bbf4115d8
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63442ba346a0eb00071d848a
Deploy Preview https://deploy-preview-3359--docs-rometools.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 07 '22 11:10 netlify[bot]

!bench_parser

IWANABETHATGUY avatar Oct 07 '22 11:10 IWANABETHATGUY

Parser Benchmark Results

group                                 main                                   pr
-----                                 ----                                   --
parser/checker.ts                     1.00    145.3±2.69ms    17.9 MB/sec    1.00    145.8±2.70ms    17.8 MB/sec
parser/compiler.js                    1.00     83.3±1.83ms    12.6 MB/sec    1.00     83.5±1.67ms    12.5 MB/sec
parser/d3.min.js                      1.00     48.7±1.17ms     5.4 MB/sec    1.00     48.6±1.07ms     5.4 MB/sec
parser/dojo.js                        1.00      4.1±0.05ms    16.6 MB/sec    1.00      4.1±0.04ms    16.5 MB/sec
parser/ios.d.ts                       1.00    126.8±2.30ms    14.7 MB/sec    1.00    127.2±2.39ms    14.7 MB/sec
parser/jquery.min.js                  1.00     12.7±0.20ms     6.5 MB/sec    1.01     12.9±0.25ms     6.4 MB/sec
parser/math.js                        1.00     99.6±1.79ms     6.5 MB/sec    1.01    100.5±1.75ms     6.4 MB/sec
parser/parser.ts                      1.03      3.0±0.05ms    16.4 MB/sec    1.00      2.9±0.04ms    16.8 MB/sec
parser/pixi.min.js                    1.01     63.5±1.85ms     6.9 MB/sec    1.00     62.7±1.77ms     7.0 MB/sec
parser/react-dom.production.min.js    1.00     17.4±0.27ms     6.6 MB/sec    1.00     17.4±0.26ms     6.6 MB/sec
parser/react.production.min.js        1.00   899.5±14.00µs     6.8 MB/sec    1.01   905.3±13.74µs     6.8 MB/sec
parser/router.ts                      1.00      2.4±0.04ms    25.1 MB/sec    1.01      2.5±0.05ms    25.0 MB/sec
parser/tex-chtml-full.js              1.00    136.7±1.85ms     6.7 MB/sec    1.00    137.2±2.28ms     6.6 MB/sec
parser/three.min.js                   1.00     70.4±1.39ms     8.3 MB/sec    1.01     71.1±1.65ms     8.3 MB/sec
parser/typescript.js                  1.00    593.4±8.25ms    16.0 MB/sec    1.01    596.8±8.12ms    15.9 MB/sec
parser/vue.global.prod.js             1.01     21.4±0.38ms     5.6 MB/sec    1.00     21.3±0.36ms     5.6 MB/sec

github-actions[bot] avatar Oct 07 '22 11:10 github-actions[bot]

@MichaReiser, Would mind helping with reviewing the code?

IWANABETHATGUY avatar Oct 10 '22 13:10 IWANABETHATGUY

This PR is stale because it has been open 14 days with no activity.

github-actions[bot] avatar Oct 25 '22 12:10 github-actions[bot]