☂️ Rome classic lint rules, with scoping

[ematipico]

Note

This rules should be implemented once https://github.com/rome/tools/issues/2488 is closed.

This is because in order to correctly implement the rule, there's need to have access to the scope.

If you want to contribute

1. make sure you understand the requirements of the rule you would like to implement;
2. comment on this very issue telling saying which rule you would like to implement;
3. create a new task issue and link to this very umbrella issue (a member of the team will eventually assign it to you);
4. open a PR;

Note: please make sure to comment the issue saying which rule you'd like to implement, this would allow better coordination between contributors. Failing to do so would penalize yourselves against contributors that had followed these simple guildelines

Note: follow the naming convention guidelines: https://github.com/rome/tools/blob/archived-js/CONTRIBUTING.md#naming-patterns

List of rules that might require scoping resolution

• [x] #2903
• [x] noUnusedVariables: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noUnusedVariables.md
• [ ] noArrayIndexKey: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noArrayIndexKey.md
• [ ] noChildrenProp: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noChildrenProp.md
• [ ] noDanger: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noDanger.md
• [ ] noDangerWithChildren: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noDangerWithChildren.md
• [ ] noRedundantShouldComponentUpdate: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noRedundantShouldComponentUpdate.md
• [ ] noRenderReturnValue: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noRenderReturnValue.md
• [ ] noUselessFragment: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noUselessFragment.md
• [ ] noVoidElementsWithChildren: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noVoidElementsWithChildren.md
• [ ] useButtonType: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/useButtonType.md
• [ ] useFragmentSyntax: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/useFragmentSyntax.md
• [ ] useInterfaces: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/ts/useInterfaces.md
• [x] noArguments: #2807
• [x] https://github.com/rome/tools/issues/2848
• [x] #2878
• [x] noImportAssign: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noImportAssign.md
• [x] #2837
• [ ] noRestrictedGlobals: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noRestrictedGlobals.md
• [ ] useSimplifiedBooleanExpression: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/ts/useSimplifiedBooleanExpression.md
• [x] #2897
• [x] #2836
• [ ] noUndeclaredVariables: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noUndeclaredVariables.md
• [ ] noFindDOMNode: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/react/noFindDOMNode.md

Note: this rule requires access to the filename, which is not implemented yet

• [ ] useDefaultExportBasename Enforce the name of the file and the name of the default function / class export matches

[Conaclos]

Some links are dead.

[ematipico]

Some links are dead.

Thank you! They should be fixed now

[IWANABETHATGUY]

@ematipico would you mind assigning me the task noCatchAssign? The related issue is here https://github.com/rome/tools/issues/2848

[IWANABETHATGUY]

@ematipico , would you mind assigning me the task noImportAssign? Related issue https://github.com/rome/tools/issues/2923

[IWANABETHATGUY]

noImportAssign is already merged.

[ematipico]

I will work on useButtonType

[ematipico]

The rule noFindDOMNode was mainly a warning of using an API meant to be deprecated. The API is now deprecated, so maybe we don't need this rule anymore