Laravel-Queue-Monitor icon indicating copy to clipboard operation
Laravel-Queue-Monitor copied to clipboard
verified publisher icon romanzipp

removed laod routes when ui disabled

Open santino83 opened this issue 2 years ago • 5 comments

Removes loading routes when UI disabled to keep routing list clean and free spots for current app routes.

santino83 avatar May 12 '23 22:05 santino83

I'd love to merge this PR but unfortunately it's incompatible with the current way of testing the routes. As you can see in this comment.

I'm happy to accept changes that will allow testing routes and won't register them automatically unless enabled.

romanzipp avatar May 13 '23 07:05 romanzipp

I will try to work on testing, but your testing framework doesn't work on my pc. Those "Lando" doesnt start, giving me a lot of errors and stucks. I will spend more on this later and try to propose again this fix

santino83 avatar May 13 '23 13:05 santino83

Hello, I have refactored tests to reflect changes made on QueueMonitorProvider. It is a bit verbose, but the solution I found works.

santino83 avatar May 13 '23 17:05 santino83

Could I have a feedback about this request?

santino83 avatar Jul 05 '23 01:07 santino83

Hey, sorry for not responding in the meantime, this PR went a bit under the radar for me. Hoever, I've publish v5 of the package now. If you'd like to rebase the code I'll be willing to merge it! Thanks!

romanzipp avatar Sep 11 '23 10:09 romanzipp