electrs icon indicating copy to clipboard operation
electrs copied to clipboard

Don't fail mempool sync on missing transactions

Open romanz opened this issue 1 year ago • 3 comments

Otherwise, RBF may cause current sync implementation to fail.

romanz avatar Jan 27 '24 09:01 romanz

It can also handle following transient RPC errors:

mempool sync failed: batch getrawtransaction request failed: transport error: Couldn't connect to host: Resource temporarily unavailable (os error 11)

romanz avatar Jan 27 '24 11:01 romanz

when running this pr on my node i got the following two messages (alongside the usual indexing 1 blocks, chain updated): missing mempool entry: 9c75d38a3eeca395a2c6bb6bb4b14bf8126334f16c2da57b7a1753b930890748 and missing mempool tx: f10483eaf7defa69ea77932b0839379466bfa5bec9a8fa9255e7aa0b1dd7ef45 (checked both on mempool.space and they both have been replaced) is this a problem or just indicates that after replacement it cant be found anymore?

antonilol avatar Jan 28 '24 16:01 antonilol

missing mempool tx/entry is common in the log, for replaced transactions. i did however find a whole list of missing mempool entry warnings followed by mempool sync failed: batch getmempoolentry request failed: transport error: Couldn't connect to host: Resource temporarily unavailable (os error 11), the transaction ids logged were all confirmed transactions from the same block

antonilol avatar Jan 29 '24 19:01 antonilol

is this a problem or just indicates that after replacement it cant be found anymore?

It is not a problem - probably just a regular RBF :)

romanz avatar Feb 23 '24 15:02 romanz

Resource temporarily unavailable (os error 11)

Has this error also happened before this PR?

romanz avatar Feb 23 '24 15:02 romanz

Resource temporarily unavailable (os error 11)

Has this error also happened before this PR?

not that i know of, at least not from 19 (log start) to 28 (first occurrence of that os error) january

antonilol avatar Feb 27 '24 22:02 antonilol

OK, thanks @antonilol! I'll merge this PR, and let's continue running it to see how it goes :)

romanz avatar Mar 02 '24 11:03 romanz