electrs icon indicating copy to clipboard operation
electrs copied to clipboard

Add blockchain.outpoint.subscribe RPC

Open romanz opened this issue 3 years ago • 8 comments

Following #444 (see the specification here).

Blocked until Electrum client is released with support of 1.5 protocol.

romanz avatar Aug 13 '21 18:08 romanz

Code looks very good to me (much better than mine in #446 obviously) and I successfully use it with janoside/btc-rpc-explorer#356

This "test" doesn't use the notification part however !

Pantamis avatar Aug 14 '21 17:08 Pantamis

Thanks for testing!

romanz avatar Aug 15 '21 18:08 romanz

Would it be possible to rebase this PR with current p2p branch ?

I would like to try #468 with my PR in the bitcoin explorer janoside/btc-rpc-explorer#356 Thanks :)

Pantamis avatar Sep 09 '21 17:09 Pantamis

Thanks for the heads-up! Rebased aec27af.

romanz avatar Sep 09 '21 18:09 romanz

I suppose you will reopen this PR once Electrum 1.5 spec are merged ?

Great work on the p2p branch !

Pantamis avatar Sep 18 '21 09:09 Pantamis

I think this was the same GitHub confusion as in #455

Kixunil avatar Sep 18 '21 10:09 Kixunil

I think this was the same GitHub confusion as in #455

Yes, reopening now :)

romanz avatar Sep 18 '21 10:09 romanz

Hi !

Just for information:

This PR still work as expected when cherry picked from master. This is mandatory since #783

The only thing that must be changed to make it compiling is BlockHash::default() to BlockHash::all_zeros() in OutpointStatus struct.

I re tACK this with janoside/btc-rpc-explorer/pull/356

Pantamis avatar Nov 01 '22 19:11 Pantamis