Roman Zeyde

Results 503 comments of Roman Zeyde

Tested mainnet query performance using https://mempool.space/address/1BitcoinEaterAddressDontSendf59kuE. Assuming warm OS block cache, https://github.com/romanz/bindex-rs/pull/63#issuecomment-3484098889 takes

[Added](https://github.com/bitcoin/bitcoin/compare/c30647c4d34c2941696729704854467b30657c43..e14650967dc95da5c10e0d6183b6eac3e8243fe5) REST API documentation and release notes & added a comment for `rest_block` (following @oren-z0 [review](https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2483977816)).

Updated [PR's description](https://github.com/bitcoin/bitcoin/pull/33657#issue-3529967048) with query performance and external offset index size for mainnet:

Thanks @andrewtoth! I have applied the patch below on e14650967d, but it seems that it didn't improve the following benchmark performance (reading the smallest possible amount of data from a...

Thanks! > Left minor comment/question in related presentation: https://docs.google.com/presentation/d/1Zez-6DApKRu59kke4i_g9jwxQlaFKKRpOPdYFYsFXfA/edit?disco=AAABwl3JY0U Good point - I've changed a bit the slide, and added a few comments. This should be similar to the [electrs...

Many thanks for the review! Pushed [`f50c0d9a3e..f33eafff0f`](https://github.com/bitcoin/bitcoin/compare/f50c0d9a3ec3b830de79d64082e9f0ab4a9fc4d2..f33eafff0f3c2698ee69ccef800bbc70a4eeae86).

Split https://github.com/bitcoin/bitcoin/commit/d2f4bccbf70031b84b6af1a6c8480c4b3071bfd7 into 3 commits: $ git lg -3 * e6eb4a57df Roman Zeyde: rest: allow reading partial block data from storage * 8f0bfb9343 Roman Zeyde: blockstorage: allow reading partial block...

Tested REST throughput using block #900000: ``` ab -k -c 1 -n 10000 'http://localhost:8332/rest/block/000000000000000000010538edbfd2d5b809a33dd83f284aeea41c6d0d96968a.bin' ``` ### d30f149360 (baseline - before this PR) ``` Concurrency Level: 1 Time taken for tests:...

Many thanks @l0rinc! I have rebased this PR over #34006 together with https://github.com/l0rinc/bitcoin/pull/61/commits/536f93df79975f50781072301947cafa4640b606 - please take a look :)

> Could you provide a patch for me which would go through every single transaction in mainchain history and query it both ways (full block + new RPC) and assert...