Roman Zeyde
Roman Zeyde
IIUC, this optimization is used for optimizing txid index scan (by early-exiting the iteration). Since currently txid index shouldn't have collisions (except [BIP-30](https://github.com/bitcoin/bips/blob/master/bip-0030.mediawiki) transactions), I'd prefer to keep the existing...
> the may be collisions in txids as long as no utxos from the utxo set would be overwritten by it. Not sure - do you mean that two different...
I think that #933 should resolve the ordering (returning the first matching tx), as well as not parsing the next blocks.
Thanks for reporting this issue! Could you attach relevant electrs logs (between 10:40 and 10:42)?
> **Describe the solution you'd like** > Cut out the RPC types from electrs to a separate crate that electrs will depend on and double check with the other crates...
Many thanks! Could you please open a separate PR for the first two commits? (You can keep these commits also in this PR, to prevent merge conflicts)
> If you feel comfortable with that, i'll submit [9b5f925](https://github.com/romanz/electrs/commit/9b5f925934de1986c803881cb866f3770a872175) and [ed42680](https://github.com/romanz/electrs/commit/ed42680992994488961bbf5aa3028a7a3d4b5dcc) as a new PR. Please do :)
Please rebase over `master` (since #971 is merged).
Seems that the CI failure is not related to https://github.com/romanz/electrs/pull/970/commits/06303d90d87100163f05b1bf2f0a72a7d280eb4f - I'll merge it via https://github.com/romanz/electrs/pull/973
Please rebase over latest `master`.