python-web-pdb
python-web-pdb copied to clipboard
romanvm
Feature/UI layout update
Hi, this is a fix/enhancment of #29
My changes are:
- Media queries
- Painted repl input so it's noticeable
- Moved toolbar to navbar to save space
A screenshot of 1920x937 inner height window
Movind the toolbar to the navbar area is a sound idea but media queries don't do a good job of dynamically adjusting the UI while the browser window is being resized. I'll post videos later if needed.
@romanvm I agree that media queries are not the best way of dealing with this stuff. I just added them for a couple of most used cases. I'm ok with removing them
Sorry, I had no time to re-test this one because of the real life stuff. I'll try to do this as soon as I can.
No worries mate, just wanted to check this out is not abandoned. This is not urgent, take care and be safe
I've finally found some time to work on this project. Could you merge the current master into this and resolve possible conflicts?
Not sure if you've seen it, but I pushed new commits, you can start a workflow, @romanvm 👍
I've tested your PR again. The idea to move the button bar to the top is a good one. But media queries do terrible job of adjusting the debugger UI to the browser's viewport compared to my initial solution. So I'm afraid I cannot accept this PR as it is now. I see 2 options:
a) you leave only the part about the button bar and restore the initial method of resizing the debugger UI;
b) you improve your resizing method (if it's possible).
I admit that my frontend skills are limited and my solution for auto-resizing the debugger UI may not be an optimal one but it does the job.
@romanvm Hi, I agree that media queries are terrible, guess I just wanted to do a quick hack. Let me see if I can come up with something better than this.
@romanvm quickly hacked a new layout using css grid, heres the showcase. It may still not work idealy on really smal screens where title wraps into 2 lines. This is not the issue of this PR, but of the the way it's coded. I might revisit this and fix this one also. Don't close this PR so I can push here. But yeah, may be give this update a review and some feedback
@romanvm had to use this lib again so just bumping this issue in case you have time in near future, no rush