image-comparison icon indicating copy to clipboard operation
image-comparison copied to clipboard

question about cli

Open jradom opened this issue 3 years ago • 14 comments

Hi Roman,

I'm very happy with your tool but we are moving towards Javascript/Typescript. Is it possible for you to build a jar with parameters input? So, I'll be able to invoke it from Typescript? Please, let me know

Thanks

Jeff

jradom avatar Nov 05 '20 06:11 jradom

Hi, @jradom. I think we can do it as a new repository, but I don't have enough time

romankh3 avatar Nov 05 '20 08:11 romankh3

Hi Roman,

Does it mean that you don't have time and desire adding CLI capabilities? Pleas, let me know one way or another

Thanks

Jeff

jradom avatar Dec 07 '20 07:12 jradom

Hi Jeff, Yes, I don't have time for it.

From my perspective, it's easy to do, so you can do it.

Thanks, Roman.

romankh3 avatar Dec 07 '20 08:12 romankh3

Roman,

I’m sorry to hear that. Well, I’ll need to switch to some other tool then.

Thanks

Jeff

Sent from my iPhone

On Dec 7, 2020, at 12:09 AM, Roman Beskrovnyi [email protected] wrote:

 Hi Jeff, Yes, I don't have time for it.

From my perspective, it's easy to do, so you can do it.

Thanks, Roman.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jradom avatar Dec 07 '20 17:12 jradom

@jradom, You know. Project is not working without consumers. Provide here functionality, which you’re using in library and I will create it.

romankh3 avatar Dec 07 '20 20:12 romankh3

FYI, I really like and so is my management but there is a competition even in open source. And the reason I can't easily do it because I'm not a real expert in such kind of tools.

Cheers (Spasibo)

Jeff

jradom avatar Dec 08 '20 02:12 jradom

Just a friendly reminder. Did you have any chance to work on my request because I'll need to use some sort of Visual testing n my upcoming Typescript project?

Thanks in advance

Jeff

jradom avatar Dec 14 '20 19:12 jradom

As I understood, you decided to stop using library at all, didn’t you? If not, provide options which you’re using in comparing. After that I will provide program.

romankh3 avatar Dec 15 '20 06:12 romankh3

Hi Roman,

It's kinda funny and might be lost in translation or miscommunication. This is what I wrote recently "FYI, I really like and so is my management but there is competition even in open source. And the reason I can't easily do it because I'm not a real expert in such kind of tools." Again I do like your tools with all features and accuracy of it, etc. And I have/had a plan to call it from my Typescript code once you'll expose options to a jar file CLI. I'd prefer to have all or most options to be exposed to CLI but make them optional with some defaults. And a simple sample code maybe in Typescript (optional). Actually, we use the Cypress UI testing tool. Again your stuff is great and I had found something similar I still will prefer to use yours. I also hope I'll be able to reuse my previous test configurations in the new project and Typescript. It'll be great if you can do it in a timely fashion. I hope I've clarified my goals.

Thanks

Jeff

jradom avatar Dec 15 '20 06:12 jradom

Oh, I think you were confused that I said if you not gonna do it I MIGHT need to switch to some other tool

jradom avatar Dec 15 '20 06:12 jradom

Ok, I think I can do it.

romankh3 avatar Dec 15 '20 09:12 romankh3

Hi Roman,

Just following up. Where are you standing with my request for CLI making? Please, let me know

Thanks

Jeff

On Tue, Dec 15, 2020 at 1:16 AM Roman Beskrovnyi [email protected] wrote:

Ok, I think I can do it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/romankh3/image-comparison/issues/199#issuecomment-745159177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4ZGPMNF7ST3B7C7TXWFIDSU4SQLANCNFSM4TK5XEJA .

jradom avatar Dec 21 '20 08:12 jradom

@romankh3 Hi, I'd like to work on the issue.

scp-WFZ avatar May 24 '22 13:05 scp-WFZ

@scp-WFZ hi, I had CLI in library in a past and removed it.

As you can see our dialoge above, it should be done in separated repository just because I want to save image-comparison as a library, not a product.

Feel free to do it in this repo: https://github.com/romankh3/image-comparison-cli

romankh3 avatar May 25 '22 05:05 romankh3