Roman Ivanov
Roman Ivanov
https://checkstyle.org/cmdline.html#Command_line_usage Please use `-t` to show ast structure. Our ast is not perfect by structure, but unfortunately if we missed inconsistency, it become set in stone.
Please do not polish code until issue is approved, we do not want to waste your time. We need to agree on general design and expectations first, there are a...
>Checkstyle violations that I can't fix without turning the whole class inside out. Put suppression on them, to bypass and see next problems, we will see how to fix it...
I am ok to make max limit as 120 lines, I glanced through files, all big files are NOT for good reason. @pbludov , @rnveach , @nmancus1 , @strkkk ,...
We do not use imports that much, header comment is not that big. Please show me input file that is good to be above 120 lines. There might few only.
count of files is not that I worry about. This task will be perfect for introduction to project, so it will be long lasting and done eventually - ok. Having...
First PR should do suppression "until #11163". If we decide to keep big input, we should make special comment.
We come to majority agreement to make it 120. We can always keep in permanent suppression cases that need more for good reason or we can make limit higher later...
@Rahulkhinchi03 , please help with this issue , it is easy, just split Input files into two or few and remove suppression.
Yes, simple update, but would require attention to details and understanding how Check works.