Roman Ivanov comments

Results 1611 comments of


                                            Roman Ivanov

JDK 25, JEP 512: Compact Source Files and Instance Main Methods not supported

Super() support is separate https://github.com/checkstyle/checkstyle/issues/17052

JDK 25, JEP 512: Compact Source Files and Instance Main Methods not supported

Workaround for now: ``` ```

JDK 25, JEP 512: Compact Source Files and Instance Main Methods not supported

Better to have exception in Checks than exception in parser. We almost always update grammar first, and then later follow up on each affected Check, one by one.

Inconsistent behaviour of `Indentation` check

Thanks a lot for detailed report!

XPath has direct connection to if comment aware checks are added or not

Good example of how presence of trailing comments make xpath to become not-matching - https://github.com/checkstyle/checkstyle/pull/7542#issuecomment-586778038

XPath has direct connection to if comment aware checks are added or not

@Harsh-Agrawal96, please share xpath that works for both configs. xpath is like regexp on tree, it is not very stable execution, as it depends on tree structure too much, but...

XPath has direct connection to if comment aware checks are added or not

@Harsh-Agrawal96, please share xpath that works for both configs. Problem is in xpath. We need provide author of issue xpath that works for all. After that we need to think...

XPath has direct connection to if comment aware checks are added or not

yes, this issue looks like does not have solution, as Xpath is fully depend on AST of code and we have limitation that AST is different by structure for Checks...

Issue checkstyle#3110: Remaining hardcoded english in ImportControlLoader.java is translated in message files

Please [read](https://github.com/checkstyle/checkstyle/blob/master/.github/CONTRIBUTING.md#getting-started) and watch videos at [Starting_Development](https://checkstyle.org/beginning_development.html#Starting_Development). Please make CI green.