Roman Ivanov
Roman Ivanov
Finished at https://github.com/checkstyle/checkstyle/pull/17216
@smita1078 , thanks a lot for your first version of implementation !!!!
Please add to Inputs https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/89419d9_2025073220/reports/diff/openjdk21/index.html#A1, it is array variable, interesting case. This is false positive https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/89419d9_2025073220/reports/diff/openjdk21/index.html#A4 please add it to inputs and update code to not put violation
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ee631c1_2025041712/reports/diff/openjdk21/index.html#A1 this is false positive, it should not be violation
``` 619 if (bundleMap.get(key) instanceof String[] sa) { 620 // fill missing elements in case of String array 621 for (int i = 0; i < sa.length; i++) { 622...
I pretty sure amount of false positives will be killing. Please consider comment https://github.com/checkstyle/checkstyle/pull/17206/files#r2140687035 I would rather use TODO comment, because bit is AST based. Wow https://checkstyle.org/checks/misc/trailingcomment.html#TrailingComment is it what...
Try `format = (default)TODO\:` `:` might be special character in property based content. Try another Check. Or send PR to show your problem, what exact problem you experience.
Choose another Check, if TodoComment is complicated for you now.
@0utplay, Can you help us validate that this fix actually covers all your problems. To build jar from this PR, please read https://github.com/checkstyle/checkstyle/pull/17135#issuecomment-2970252097 Thanks s lot in advance
@Aziz-755 , can you check behavior on trinodb https://github.com/checkstyle/checkstyle/issues/17163#issuecomment-2953491406 Looks like we have access to their sources, and it is them reporting this issue initially. We can add their codebase...