Roman Ivanov
Roman Ivanov
I am ok with this design, we can cover static too because if it is private and not used, then static/final/.....any extra modifiers... does not matter. We need to add...
@rnveach , ok, are you ok with 2 extra properties and design of Check?
I am ok with splitting and implementing extra properties as separate issue/PRs. @nrmancuso , please review and approve issue.
@Zeeshan3h3 , please start with issues labeled "good xxxx issue" . Please [read](https://github.com/checkstyle/checkstyle/blob/master/.github/CONTRIBUTING.md#getting-started) and watch videos at [Starting_Development](https://checkstyle.org/beginning_development.html#Starting_Development).
@Atharv3221 , to both questions - "yes".
@AmitKumarDeoghoria , https://github.com/checkstyle/checkstyle/blob/5999226299cedb2bd3926b1fd648792ca86e28d7/.ci/error-prone-check.groovy#L9C33-L9C41 we just need to move `@Field static final Set PROFILES = Set.of("compile", "test-compile")` to be in defined in some method, let put it above https://github.com/checkstyle/checkstyle/blob/5999226299cedb2bd3926b1fd648792ca86e28d7/.ci/error-prone-check.groovy#L36C5-L36C39 try: `if...
we are blocked by https://github.com/checkstyle/contribution/issues/980
Please [read](https://github.com/checkstyle/checkstyle/blob/master/.github/CONTRIBUTING.md#getting-started) and watch videos at [Starting_Development](https://checkstyle.org/beginning_development.html#Starting_Development). Please make CI green.
CI is red. Keep in mind, you can put capricious cases to separate PR, let merge quicker simple case
`Failed to execute goal org.pitest:pitest-maven:1.20.2:mutationCoverage (default-cli) on project checkstyle: Line coverage of 99(445/446) is below threshold of 100 -> [Help 1]` We lost test coverage, we value test coverage more...