Roman Ivanov
Roman Ivanov
Last clarification https://github.com/checkstyle/checkstyle/pull/17206#discussion_r2175127951
Only xwiki and "closed issues" CI fails are expected, all others are not, please address
@rdiachenko , please finish review.
Github, generate report for Regexp/all-examples-in-one
@mohitsatr , good, thanks a lot, please address CI failures https://github.com/checkstyle/checkstyle/actions/runs/11536785686/job/32113430598?pr=15761#step:6:428 https://app.circleci.com/pipelines/github/checkstyle/checkstyle/28436/workflows/bd96e120-3148-492b-86bf-3f77c71deeb5/jobs/711882/artifacts All CIs should be green.
Xwiki failure is not related.
Github, generate report for Regexp/all-examples-in-one
@rdiachenko , please finalize review
@mohitsatr , thanks a lot for your hard work on this. I hope you see that writing good code is challenging. Whole our project is about not just a code...
>Now take a look at the following code produced by google-formatter. It puts the right-bracet ) back to previous line, after the " of string. It expects no line break...