Roman Shterenzon
Roman Shterenzon
When I come to think about it, the default should be [t0,t1] (and a boolean for going through [t0,weth,t1] route) and in case such pair doesn't exist an exception thrown...
Insufficient liquidity is caveat emptor. But maybe some safeguard is needed indeed...
There's a pending PR https://github.com/uniswap-python/uniswap-python/pull/159
@rmurray2 I'm working on that, although the code is not based upon uniswap-python, but rather tries to follow the official uniswap-v3-sdk (javascript). If anyone is interested to participate in this...
@liquid-8 how would you do that? As far as I know uniswap doesn't have a history of trades. Are you referring to tracing the transactions with router?
Right, this is what I assumed. I'm curious, what is the real-world use case of such history of trades? Apart from academic interest, one can extrapolate the activity between two...
Some other blockchains hadn't adopted EIP-1559 yet, so IMHO the sensible way to proceed is either have a constructor parameter for enabling EIP-1559 or allow a callable that will be...
I hope to see this feature :)
I rebased it on the current develop branch
I don't have time to support this at the moment, but I'll be happy to receive a PR.