cljs-rum-realworld-example-app icon indicating copy to clipboard operation
cljs-rum-realworld-example-app copied to clipboard

Published 20 hours ago • verified publisher icon roman01la

Add authorization

Open lavgl opened this issue 7 years ago • 6 comments

I'd like to implement auth as a next part. This covers:

  • [x] 'Sign in' page
  • [x] 'Sign up' page
  • [x] Differentiating navigation menu for logged and non-logged users
  • [ ] 'Log out' button on 'Settings' page
  • [x] Storing user info and jwt token

I suppose this functionality will be covered by several PRs.

lavgl avatar Aug 28 '17 21:08 lavgl

LGTM

roman01la avatar Aug 28 '17 21:08 roman01la

Sorry for jumping in, but I have some code ready for review if you don't mind me taking this task.

foopang avatar Aug 29 '17 01:08 foopang

Sure I don't. Do you want to cover all the functionality described above?

lavgl avatar Aug 29 '17 07:08 lavgl

Yes, I have all the functionality described above covered already in https://github.com/roman01la/cljs-rum-realworld-example-app/pull/7. But the PR is not approved by @roman01la. I will try to break it down into several PRs.

foopang avatar Aug 29 '17 07:08 foopang

@foopang Thanks!

roman01la avatar Aug 29 '17 08:08 roman01la

@foopang One thing that might save you a bit of time: try to stick to a code style of the project as much as you can, for example component names should be camel cased starting with a capital character. Basically see how the rest of the code is written and try to write your code in same manner. We want the code base to be consistent, because this project is intended to serve as a reference for others.

roman01la avatar Aug 29 '17 09:08 roman01la