Romain Thomas comments

Results 187 comments of


                                            Romain Thomas

Adding section to ARM ELF causes problem in file size

Hi @Miniman2718 > Which kernel/loader are you referring to? Linux loader/kernel and yes I agree that it can works without a PHDR segment (in the case of static binary). >...

Adding section to ARM ELF causes problem in file size

> which is different from what I think va % pagesize() == offset means. Could it be possible that you chose to use Yes you are right, I missed the...

Adding section to ARM ELF causes problem in file size

Indeed it works and it passes the test suite. I re-open the issue and I'll take a closer look a these updates. Thank you pushing your idea even though I...

Speed up ELF symbol lookup

Hi @wannacu Thank you for this interesting PR!. Some remarks though: 1. It uses `std::string_view` in public headers which raises the minimum C++ version from 11 to 17. I would...

Layout check of __LINKEDIT segment fails for modified binary

True. Actually the `binary` instance after a write operation can't be considered as consistent. This is why most of the tests are done on a reloaded instance. I agree it's...

Layout check of __LINKEDIT segment fails for modified binary

Sorry actually I misread the where the error occurs. I agree that `check_layout` should run correctly after the `extend_section`.

Java Class files misidentified as Mach-O FAT files in `is_macho()`

You are right I'll see how to improve this check

Java Class files misidentified as Mach-O FAT files in `is_macho()`

Done!

Support for adding dynamic symbol binding to Mach-O binaries

Thanks for this detailed issue. It's definitely something that will be added for the next version of LIEF

Shifting the text segment invalidates load address relative addresses in MachO binaries

I confirm the issue on my end. I'll investigate more to check if there is a fix for this situation