Shimmer-android icon indicating copy to clipboard operation
Shimmer-android copied to clipboard

Memory Leak

Open lawloretienne opened this issue 8 years ago • 3 comments

Does the Runnable inside Shimmer.java properly stop? It seems to be causing a memory leak for me.

lawloretienne avatar Oct 06 '16 21:10 lawloretienne

Here is what the leak looks like : https://gist.github.com/lawloretienne/66ed381b89d543bff6ede5016a0d0ce0

lawloretienne avatar Oct 06 '16 22:10 lawloretienne

Same problem here!

RockyLin avatar Feb 11 '17 02:02 RockyLin

Shimmer shimmer = new Shimmer();

... shimmer.start(tvShimmerText); ...

Cancel shimmer in onDestroy() might help you.

@Override
    protected void onDestroy() {
        super.onDestroy();
        if (shimmer!=null) {
            shimmer.cancel();
            shimmer = null;
            tvShimmerText = null;
        }
    }

nieldeokar avatar Oct 26 '17 16:10 nieldeokar