Apprentice icon indicating copy to clipboard operation
Apprentice copied to clipboard

Vim patch 9.0.0032: Cursorline + QuickFixLine no longer look right together

Open puremourning opened this issue 2 years ago • 4 comments

There's always been a weird interaction between cursor line highlight and QuickFix current line highlight.

Steps to repro:

  • Using vim 9.0.0032 in the vim build directory, run : env VIMRUNTIME=$(pwd)/runtime ./src/vim --clean --cmd 'set rtp+=$HOME/.vim/bundle/Apprentice' --cmd 'colorscheme apprentice' --cmd 'set termguicolors' --cmd 'set cursorline' -c 'grep edit src/edit.c' -c 'copen'
  • ctrl-w j - jump to quick fix
  • see that the cursor line highlight and the quick fix line highlights make the text unreadable.

Screenshot:

Screenshot 2022-07-12 at 15 58 55

Demo showing both current and previous:

https://asciinema.org/a/xxn6mnepdN5qfrYN6GUD8ju9J

puremourning avatar Jul 12 '22 15:07 puremourning

Without apprentice colorscheme:

  1. get into vim source directory
  2. vim -Nu NONE
  3. :grep vim9
  4. :hi Cursorline ctermbg=236
  5. :set cursorline
  6. :copen
  7. place cursor to the selected quickfix line

image

I guess https://github.com/vim/vim/issues/10654 should be either reverted or implemented as was suggested, Cursorline overrides Quickfixline.

habamax avatar Jul 12 '22 17:07 habamax

damn, I thought I was doing it in vim repo :(

habamax avatar Jul 12 '22 17:07 habamax

I forget to create a branch for the desert fix in vim/colorschemes, you think you are in vim/vim… what the hell is going on?

romainl avatar Jul 12 '22 18:07 romainl

It's my aura. It has this effect on people. Some sort of distortion field.

puremourning avatar Jul 12 '22 18:07 puremourning

The issue has been fixed upstream:

Capture d’écran 2022-08-26 à 08 08 52

romainl avatar Aug 26 '22 06:08 romainl