react-portal-tooltip icon indicating copy to clipboard operation
react-portal-tooltip copied to clipboard

Published 20 hours ago • verified publisher icon romainberger

[Feature Request] TypeScript support

Open stargazing-dino opened this issue 5 years ago • 4 comments

Would love to see a types file defined for this library as it really is good.

stargazing-dino avatar May 20 '19 17:05 stargazing-dino

PRs always welcome :wink:

I've been using a lot of Typescript lately. If you don't care to make a PR adding typings (or converting to TS, though I'm not sure how @romainberger feels about a full conversion) I might be able to get around to it eventually. I've been insanely busy so I haven't had the chance or motivation to check on this library in a while.

Redmega avatar May 22 '19 21:05 Redmega

Yeah I haven't used Typescript for now so if there is a possibility to keep it as is and add types separately that'd be cool 👍

romainberger avatar May 23 '19 08:05 romainberger

I've never written one but I think I could figure it out. If anyone else feels the urge to write one and get a PR in quick, please don't let me stop you

stargazing-dino avatar May 23 '19 15:05 stargazing-dino

Hi, I created types @ definitely typed.

Now in PR https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45221

naortor avatar Jun 02 '20 04:06 naortor