Romain
Romain
AWESOME!! We should probably also change S3_WORKER_COUNT to something like this instead of using 64 all the time (that may be more debatable but we have had issues when it...
Need to see why this is not testing -- there is a load problem. May be an ordering issue. I will check (we now use secrets too). Thanks for trying...
I'll take a look a bit closer but one thing I can say already is that we probably want to min it with what is already there because otherwise if...
Argh -- ok, let me push a fix for that. Fixed a bunch of other issues with configs but introduced a new one. Should be an easy fix. Sorry about...
Of course -- I am not currently working on it. But yes, it would apply to the objects in the client/core.py file so flows to artifacts.
Good point. We can make this more robust. May I ask how you are using the escape hatch. It's a fairly obscure feature (we use it quite a bit but...
Alright, I finally got around to this and there is an issue that is minor but nonetheless: - This line: https://github.com/Netflix/metaflow/blob/master/metaflow/cli.py#L173 breaks The reason for this (I think) is that:...
OK, I like where this is going. Yes, I think you are right that we should indicate the file and line number. I think we also need to add the...
Alright. Why are the tests not running here. I'll run them internally and check.
OK, the changes look good to me, I just need to probably make a few changes here: https://github.com/Netflix/metaflow-nflx-extensions/blob/main/metaflow_extensions/netflix_ext/cmd/debug/debug_script_generator.py#L409 (and probably a few other places) so that it doesn't break when...