Romain Vimont

Results 2060 comments of Romain Vimont

Thank you for the detailed answer. I will read in details a bit later. Just a quick question: > Instead of releasing/creating a new VirtualDisplay (avoiding displayId increase) Why is...

Oh, I'm had never noticed that mirroring the device created a new display id (listed by `scrcpy --list-displays`) with `createVirtualDisplay()` (be3f949aa5c4dcad276ac0f2b36671a3309ce12f). Maybe there is another method which does not create...

Indeed (but I think this is true only for Android 14, on my older devices it does not create a new display id).

With your commit from this PR, and this additional hack to force using the DisplayManager API: ```diff diff --git a/server/src/main/java/com/genymobile/scrcpy/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/ScreenCapture.java index 6f9c4d338..d04fad572 100644 --- a/server/src/main/java/com/genymobile/scrcpy/ScreenCapture.java +++ b/server/src/main/java/com/genymobile/scrcpy/ScreenCapture.java @@ -41,6...

> Could you please post the screenshot of the incorrect capture? In fact, it is not a corrupted image: on device rotation, sometimes (not always, so there's probably a race...

Nope, with or without these lines, I can reproduce the problem. Besides, this is probably not an "incorrect" rotation value, it looks like a race condition (80% of times, it...

:open_mouth: Do you encounter this problem with current `dev` branch on rotation, without passing `--crop` or `--lock-video-orientation`?

How did you build/install scrcpy and its dependencies? Please build in debug mode (still with ASAN): ``` meson setup d -Db_sanitize=address ninja -Cd ``` and run: ``` ./run d -d...

Just to test, this works: ```diff diff --git a/app/src/event_converter.c b/app/src/event_converter.c index ab48898d..dc88c239 100644 --- a/app/src/event_converter.c +++ b/app/src/event_converter.c @@ -96,6 +96,9 @@ convert_keycode(SDL_Keycode from, enum android_keycode *to, uint16_t mod, MAP(SDLK_RCTRL, AKEYCODE_CTRL_RIGHT);...

Does it work for you: ``` adb shell input keyevent MEDIA_PLAY_PAUSE ``` ? On some laptops, Fn is "enabled" by default (customizable from BIOS/UEFI), so you need to press Fn+F9.