Rodrigo López Dato

Results 72 comments of Rodrigo López Dato

Planning on deprecating `IFlagsmithConfiguration` as part of this change as well. It's purely a data object with no methods, except for an `IsValid` method that is not called anywhere, which...

Even easier way to reproduce this issue: try to create a feature with a duplicated name.

@kyle-ssg Yes that's correct, I thought I had reproduced it elsewhere but it's only in the feature modal.

@beeme1mr Would you please assign this issue and https://github.com/open-feature/js-sdk-contrib/issues/1232 to me? Thanks!

One for @kyle-ssg to have a look maybe? I can't assign reviewers for this PR while it's still in draft.

Thanks @beeme1mr - there is actually a behavior change in this PR here, in case you missed it: https://github.com/open-feature/js-sdk-contrib/pull/1351/files#diff-6f058ad4a6f79177acf735cd905843b3a9f0a1f28e1493058d6dc3449a0fd3d2

> Request 1 comes in with no traits and gets a set of flags back. > Request 2 comes in with some traits. These traits may impact the flags returned...

I see, thanks for the clarification. All server-side Flagsmith clients have caching implemented this way. If I understand correctly, to support the behaviour you describe, you would need to share...

To add another data point, this is also how OpenFeature works; specifically, the dynamic context paradigm for server-side SDKs: https://openfeature.dev/docs/reference/concepts/evaluation-context/#dynamic-context-implementations-server-side-sdks The evaluation context (i.e. identity and traits in Flagsmith terms)...