chore(repo): update eslint and remove workaround

[tjenkinson]

Rollup Plugin Name: NA

This PR contains:

• [ ] bugfix
• [ ] feature
• [ ] refactor
• [ ] documentation
• [x] other

Are tests included?

• [ ] yes (bugfixes and features will not be merged without tests)
• [x] no

Breaking Changes?

• [ ] yes (breaking changes will not be merged unless absolutely necessary)
• [x] no

List any relevant issue numbers: closes #977

Description

See the linked ticket. With the eslint and prettier update we shouldn't need the workaround this PR removes anymore which was to handle an eslint crash if there was a folder called "package.json".

[tjenkinson]

Ugh this is a can of worms. Now it's looking like the same bug exists in prettier /0\

Oops! Something went wrong! :(

ESLint: 7.32.0

Error: EISDIR: illegal operation on a directory, read
Occurred while linting /Users/tomjenkinson/Documents/GitHub/plugins/packages/node-resolve/test/fixtures/package-json-in-path/package.json/main.js:1
    at Object.readSync (node:fs:625:3)
    at tryReadSync (node:fs:390:20)
    at Object.readFileSync (node:fs:427:19)
    at readFileSync (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9675:35)
    at ExplorerSync.loadSearchPlaceSync (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9993:51)
    at ExplorerSync.searchDirectorySync (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9979:34)
    at run (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9959:29)
    at cacheWrapperSync (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9715:20)
    at ExplorerSync.searchFromDirectorySync (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9971:52)
    at run (/Users/tomjenkinson/Documents/GitHub/plugins/node_modules/.pnpm/[email protected]/node_modules/prettier/third-party.js:9963:23)

[tjenkinson]

blocked on https://github.com/prettier/prettier/pull/11382 going into stable version

[tjenkinson]

@shellscape any idea why tests are failing on CI?

pnpm ci:coverage --filter "...[master]" is working fine for me locally on node v16.9.0

Somewhere in the logs I see packages/pluginutils ci:coverage: ✖ Timed out while running tests but there isn't much more to go on :/

[tjenkinson]

When I run run pnpm test -r on master some tests fail actually so wonder if it might be related to that?

[shellscape]

Closing this one as complete. @lukastaegert did a bunch of work to resolve this.