plugins icon indicating copy to clipboard operation
plugins copied to clipboard

chore(commonjs): switch to fdir for fewer dependencies

Open benmccann opened this issue 1 year ago • 1 comments

Rollup Plugin Name: @rollup/plugin-commonjs

This PR contains:

  • [ ] bugfix
  • [ ] feature
  • [x] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [x] yes (bugfixes and features will not be merged without tests)
  • [ ] no

Breaking Changes?

  • [x] yes (breaking changes will not be merged unless absolutely necessary)
  • [ ] no

Description

Note that this incorporates https://github.com/rollup/plugins/pull/1740

glob pulls in 27 dependencies: https://npmgraph.js.org/?q=glob fdir pulls in none: https://npmgraph.js.org/?q=fdir

benmccann avatar Jun 27 '24 22:06 benmccann

Okay, I'm embarrassed that I haven't read the PR description properly 🤦🏻‍♂️ I didn't realise this includes a different PR which would update PNPM to v9 ... Ignore that part of my review, then :D

kytta avatar Aug 15 '24 10:08 kytta