plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Published 20 hours ago • verified publisher icon rollup

fix(typescript): rolve the problem of wrong output path of type file …

Open croatialu opened this issue 1 year ago • 6 comments

rolve the problem of wrong output path of type file during construction

Rollup Plugin Name: @rollup/plugin-typescript

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

croatialu avatar Sep 02 '22 17:09 croatialu

Thanks for the PR. This will need tests before we can review it.

shellscape avatar Sep 02 '22 19:09 shellscape

Can this get pushed faster? A lot of builds are broken because of this

chaitanyapotti avatar Sep 09 '22 10:09 chaitanyapotti

@chaitanyapotti No. The change does not pass existing tests and does not have new tests. You don't merge a fix because it addresses one issue only to cause 10 more.

shellscape avatar Sep 09 '22 11:09 shellscape

Of course. I was commenting so that the pr owner can address your comments to get this merged.

chaitanyapotti avatar Sep 09 '22 11:09 chaitanyapotti

Please don't do that. It's unnecessary noise that is rarely appreciated.

shellscape avatar Sep 09 '22 12:09 shellscape

Can this get pushed faster? A lot of builds are broken because of this

Sorry, I don't have the energy to continue to fix this problem recently。But as a temporary solution for now, I use rollup and tsc to build

like this: package.json#L36

croatialu avatar Sep 15 '22 16:09 croatialu

Closing as abandoned.

shellscape avatar Oct 24 '22 17:10 shellscape