plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Documentation suggests to use namedExports even though it's been removed.

Open danieljarrett74 opened this issue 2 years ago • 2 comments

  • Rollup Plugin Name: commonjs
  • Rollup Plugin Version:

Documentation Is:

  • [x ] Missing
  • [ ] Needed
  • [ x] Confusing
  • [ ] Not Sure?

Please Explain in Detail...

If you see here: https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module

there is a statement:

It can be solved by using the [namedExports](https://github.com/rollup/plugins/tree/master/packages/commonjs#custom-named-exports) option, which allows you to manually fill in the information gaps.

However named exports no longer exists in the commonjs plugin. So the solution is a dead end.

Your Proposal for Changes

fix the documentation to provide information that helps to solve the issue in a new way given that namedExports no longer exists.

danieljarrett74 avatar Jul 21 '22 18:07 danieljarrett74

Has there been any news on this?

NikkiTheBugSlayer avatar Aug 10 '22 12:08 NikkiTheBugSlayer

@NikkiTheBugSlayer if you don't see activity in this issue, then there has been no activity.

shellscape avatar Aug 10 '22 12:08 shellscape

There are some bogus "warnings" like 'randomFillSync' is not exported by 'virtual:crypto' probably related to this one. Yes, I know what I'm doing, and yes my own virtual:crypto does export everything (including randomFillSync) exactly as needed.

pkit avatar Oct 06 '22 15:10 pkit

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

stale[bot] avatar Dec 23 '22 19:12 stale[bot]