qo0-csgo icon indicating copy to clipboard operation
qo0-csgo copied to clipboard

Published 20 hours ago • verified publisher icon rollraw

Remove the deprecated D3DX9 library

Open codecheck01 opened this issue 3 years ago • 3 comments

References

  • https://walbourn.github.io/living-without-d3dx/
  • https://walbourn.github.io/the-zombie-directx-sdk/
  • https://docs.microsoft.com/en-us/windows/win32/directx-sdk--august-2009-
  • https://github.com/ocornut/imgui/blob/c71a50deb5ddf1ea386b91e60fa2e4a26d080074/docs/CHANGELOG.txt#L2990
  • https://github.com/ocornut/imgui/blob/440824d4314b59049a196e9e6964d8e72aed25bd/backends/imgui_impl_dx9.cpp#L123

  • Delete: d3dx9.lib https://github.com/rollraw/qo0-base/blob/101e504a4cebdc9851502463ad7df46dbbb5b116/base/cinnamon.vcxproj#L235

  • Delete: d3dx9.lib https://github.com/rollraw/qo0-base/blob/101e504a4cebdc9851502463ad7df46dbbb5b116/base/cinnamon.vcxproj#L261

  • Delete: d3dx9.lib https://github.com/rollraw/qo0-base/blob/101e504a4cebdc9851502463ad7df46dbbb5b116/premake5.lua#L76

  • Delete: #include <d3dx9.h> https://github.com/rollraw/qo0-base/blob/e19f443302ba954c2b534db953b6b69511174983/base/common.h#L94

  • Delete: d3dx9.lib - directx rendering https://github.com/rollraw/qo0-base/blob/e19f443302ba954c2b534db953b6b69511174983/base/common.h#L83

  • Rename line 3 to line 2 https://github.com/rollraw/qo0-base/blob/e19f443302ba954c2b534db953b6b69511174983/base/common.h#L84

  • Delete: $(DXSDK_DIR)Include; + $(DXSDK_DIR)Lib\x86; https://github.com/rollraw/qo0-base/blob/101e504a4cebdc9851502463ad7df46dbbb5b116/base/cinnamon.vcxproj#L207-L208

  • Delete: $(DXSDK_DIR)Include; + $(DXSDK_DIR)Lib\x86; https://github.com/rollraw/qo0-base/blob/101e504a4cebdc9851502463ad7df46dbbb5b116/base/cinnamon.vcxproj#L215-L216

Next double check in <ExternalIncludePath> and <LibraryPath> if the various WindowsSDK references are actually being used, I am not using these in the latest version of Windows 10, one single reference should be used.

codecheck01 avatar Feb 07 '22 19:02 codecheck01

Do you know that CS:GO using directx 9?)

master-of-darkness avatar Feb 07 '22 20:02 master-of-darkness

don't quite remember why i left it (probably imgui shit), but we have enough exports anyway and the only benefit is one less dependency that isn't the real case

rollraw avatar Feb 07 '22 22:02 rollraw

Do you know that CS:GO using directx 9?)

You have no idea what this is about then.

don't quite remember why i left it (probably imgui shit), but we have enough exports anyway and the only benefit is one less dependency that isn't the real case

Ok, feel free to keep it, this was just about optimization.

ghost avatar Feb 07 '22 22:02 ghost

fixed with the new v2 version and now available under 'master' branch.

rollraw avatar Jun 01 '23 12:06 rollraw