rolling-scopes
feat: add terms of service checkbox to students registry
🟢 Add deploy label if you want to deploy this Pull Request to staging environment
🧑⚖️ Pull Request Naming Convention
- Title should follow Conventional Commits
- Do not put issue id in title
- Do not put WIP in title. Use Draft PR functionality
- Consider to add
area:*label(s)
- [x] I followed naming convention rules
🤔 This is a ...
- [ ] New feature
- [ ] Bug fix
- [ ] Performance optimization
- [ ] Refactoring
- [ ] Test Case
- [ ] Documentation update
- [x] Other
🔗 Related issue link
Describe the source of requirement, like related issue link.
💡 Background and solution
Students ignore the existence of documentation and announcement channel. Because of this, they miss important information. I think that by additionally agreeing to monitor announcements from course supervisors and familiarize themselves with the documentation, fewer students will get into unpleasant situations in the learning process.
My solution is to add a checkbox about “docs and announcements” to the registration form, similar to the existing checkbox about data processing. The component itself for this checkbox and things for it was written similar to the DataProcessingCheckbox component.
☑️ Self Check before Merge
⚠️ Please check all items below before review. ⚠️
- [x] Database migration is added or not needed
- [x] Documentation is updated/provided or not needed
- [ ] Changes are tested locally
⚠️ Unfortunately, I do not have the opportunity to test the changes locally, because it was not possible to run the project in my environment. I hope to find someone who can run the project locally and check if I am missing something and if everything is ok.
I have no idea what to do with https://github.com/rolling-scopes/rsschool-app/actions/runs/11167684526/job/31044423677?pr=2534
In my opinion, adding such a checkbox will not affect whether students read the announcements and documentation, but will only overload the registration form. I also think that this is not part of the registration process, as it relates more to the rules of specific courses.
And one more argument from my side: we already have notifications that users can subscribe to, and if those don't help keep them informed of important updates, then a checkbox clearly won't be of much use either.