rsschool-app icon indicating copy to clipboard operation
rsschool-app copied to clipboard

feat: migrate 'profile/info' route to nestjs

Open aidfromdeagland opened this issue 1 year ago • 0 comments

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • [x] I followed naming convention rules

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Performance optimization
  • [ ] Refactoring
  • [ ] Test Case
  • [ ] Documentation update
  • [x] Other

🔗 Related issue link

https://github.com/rolling-scopes/rsschool-app/issues/2394

💡 Background and solution

added nestJs route handling for GET 'profile/info' route removed koa-related GET 'profile/info' rote handling code (currently in progress) fixed typos: Endorment -> Endorsement, isContactsNodesVisible -> isContactsNotesVisible(bug) verification screenshots are below:

screenshots are presented in pairs: backed by koa in master branch/backed by nestjs in feature branch whole bunch of screenshots: https://drive.google.com/drive/folders/1s5qb-Um8lwAyd-sGzQUfMeEBdx0ffgBb?usp=drive_link

isAdmin: true: profileInfo page: self, mentor, no relation: localhost_3000_profile_admin_koa localhost_3000_profile_admin_nest

localhost_3000_profile_githubId=anik188_admin_koa localhost_3000_profile_githubId=anik188_admin_nest

localhost_3000_profile_githubId=apalchys_admin_koa localhost_3000_profile_githubId=apalchys_admin_nest

isAdmin: false: profileInfo page: self, mentor, no relation: localhost_3000_profile_no-admin_koa localhost_3000_profile_no-admin_nest

localhost_3000_profile_githubId=anik188_no-admin_koa localhost_3000_profile_githubId=anik188_no-admin_nest

localhost_3000_profile_githubId=apalchys_no-admin_koa localhost_3000_profile_githubId=apalchys_no-admin_nest

dashboard page: localhost_3000_course_student_dashboard_course=test-course_no-admin_koa localhost_3000_course_student_dashboard_course=test-course_no-admin_nest

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • [x] Database migration is added or not needed
  • [x] Documentation is updated/provided or not needed
  • [x] Changes are tested locally

aidfromdeagland avatar Feb 01 '24 10:02 aidfromdeagland