rsschool-app
rsschool-app copied to clipboard
feat: migrate 'profile/info' route to nestjs
🟢 Add deploy
label if you want to deploy this Pull Request to staging environment
🧑⚖️ Pull Request Naming Convention
- Title should follow Conventional Commits
- Do not put issue id in title
- Do not put WIP in title. Use Draft PR functionality
- Consider to add
area:*
label(s)
- [x] I followed naming convention rules
🤔 This is a ...
- [ ] New feature
- [ ] Bug fix
- [ ] Performance optimization
- [ ] Refactoring
- [ ] Test Case
- [ ] Documentation update
- [x] Other
🔗 Related issue link
https://github.com/rolling-scopes/rsschool-app/issues/2394
💡 Background and solution
added nestJs route handling for GET 'profile/info' route removed koa-related GET 'profile/info' rote handling code (currently in progress) fixed typos: Endorment -> Endorsement, isContactsNodesVisible -> isContactsNotesVisible(bug) verification screenshots are below:
screenshots are presented in pairs: backed by koa in master branch/backed by nestjs in feature branch
whole bunch of screenshots: https://drive.google.com/drive/folders/1s5qb-Um8lwAyd-sGzQUfMeEBdx0ffgBb?usp=drive_linkisAdmin: true:
profileInfo page: self, mentor, no relation:
isAdmin: false:
profileInfo page: self, mentor, no relation:
dashboard page:
☑️ Self Check before Merge
⚠️ Please check all items below before review. ⚠️
- [x] Database migration is added or not needed
- [x] Documentation is updated/provided or not needed
- [x] Changes are tested locally