strong_type icon indicating copy to clipboard operation
strong_type copied to clipboard

Add the STRONG_TYPE_MODULE_EXPORT to all entities that should be exported, aka strong_type module part 1

Open davidhunter22 opened this issue 1 year ago • 4 comments

Add a macro STRONG_TYPE_MODULE_EXPORT. This at some point will expand to export in a module build and empty in a non module build. Only entities in the strong_type namespace were decorated, anything in "impl", "detail" etc... namespaces were not, although see below.

The header file type.hpp contains

#if !defined(STRONG_TYPE_MODULE_EXPORT)
#define STRONG_TYPE_MODULE_EXPORT
#endif

This allows existing include users to carry on including without any changes

There should be no other changed in this patch. In my local build I have built a module and built all the test cases against it, at least on MSVC. In doing this there were two methods called access in the type.hpp header that are used in the implementation of other exported stuff so they had to be exported.

I included the strong_type.ixx file just for you interest, it will probably change a bit from this. I believe that all the other changes in the library header files are messing around with #include stuff by macroing them in or out as necessary.

These changes should not overlap at all with the import std; pull request so could be applied in either order.

davidhunter22 avatar Sep 04 '24 18:09 davidhunter22

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d6be4b9) to head (0576a60).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          338       356   +18     
=========================================
+ Hits           338       356   +18     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 07 '24 13:09 codecov[bot]

Are you waiting on me to do anything on this and the other PR?

davidhunter22 avatar Nov 07 '24 01:11 davidhunter22

No, sorry, I got stuck on a ton of other things. It is not impossible that I will ask for your assistance, but for the moment I'm a bit swamped with other things.

rollbear avatar Nov 07 '24 08:11 rollbear

No problem I'll just check back every so often

davidhunter22 avatar Nov 10 '24 18:11 davidhunter22