rollbar.js icon indicating copy to clipboard operation
rollbar.js copied to clipboard

Rollbar's npm package shouldn't contain unnecessary code

Open SkeLLLa opened this issue 6 years ago • 2 comments

Currently rollbar's npm package contains a lot of files that are useless when using it. For example, now it contains test directory, makefiles, src directory and so on.

Such files only increase package size and, for example, could and will have negative impact on lambda function init time.

SkeLLLa avatar Nov 25 '19 14:11 SkeLLLa

@SkeLLLa There are a variety of ways the npm package gets used. Some of the things you suggest could probably be removed, but others not. Have you considered using webpack to build your Lambda file? This would help ensure the smallest footprint for all your npm packages, vs zipping node_modules.

waltjones avatar Nov 25 '19 22:11 waltjones

Using webpack for node.js project is bad practice, so it's not an option. I think if rollbar package is used in "many ways" it would be better to have some dedicated repos for that. E.g. node-rollbar for node.js, rollbar - for browsers and so on. Or it can be rollbar-minimal with only necessary files.

SkeLLLa avatar Nov 26 '19 08:11 SkeLLLa