rollbar-react-native
rollbar-react-native copied to clipboard
Hardcoded minSdkVersion causes build failure when building for Detox
Hi,
Thank you for your work on this project.
I'd like to address a concern regarding the usage of Rollbar-react-native. It appears that the library does not adhere to the best practice of passing through minSdkVersion from the project's build.gradle file. While there might be valid reasons for this decision (unknown to me), it is causing difficulties when using Detox. The build process fails when the minSdkVersion specified in the Rollbar-react-native library is lower than the one indicated in the project's build.gradle file.
To address this issue, I've resorted to using patch-package as a temporary fix. However, this solution is clearly far from ideal.
See this (old but still accurate) issue on GitHub.
Thank you once again, Daan
The latest release drops the minSdkVersion to 16 (from 19), matching the current value in the rollbar-android dependency. This isn't a final solution, but hopefully helps some people.
https://github.com/rollbar/rollbar-react-native/releases/tag/v1.0.0-beta.2