rollbar-php icon indicating copy to clipboard operation
rollbar-php copied to clipboard

Plans for psr/log v.3?

Open Chris53897 opened this issue 3 years ago • 2 comments

Enhancement:

Hi, Are there any plans to migrate from psr/log from v2 to v3 ? I did a quick look into the code, and i think it is not so easy to change it.

actual: #public function log($level, $toLog, array $context = array())

psr/log v.3 public function log($level, string|\Stringable $message, array $context = []): void

Problem 1 the return instead of void. Problem 2 $toLog has a different type.

Maybe a solution could be to remove psr/log in the long term? So usere are not tied to v1|v2

Greetz

Chris53897 avatar May 03 '22 15:05 Chris53897

This is a good question. You can find more details about the this topic here https://github.com/rollbar/rollbar-php-laravel/issues/128#issuecomment-1052377338.

danielmorell avatar May 12 '22 12:05 danielmorell

Until we have a clear roadmap to v4 this is not really an option. I am going to close this issue for now, and we will revisit it once we start working on a v4.

danielmorell avatar May 21 '22 00:05 danielmorell

This has been resolved and will be part of our v4.0 release.

danielmorell avatar Dec 20 '22 15:12 danielmorell

@danielmorell Sounds good. Can you provide an UPGRADE.md in the 4.x Branch with infos what changed, and how to migrate v3 => v4? Maybe the 5.x branch of https://github.com/rollbar/rollbar-php-symfony-bundle needs some changes to support v4.

Chris53897 avatar Dec 25 '22 12:12 Chris53897

@Chris53897 I added an issue to create upgrade documentation (see #599).

danielmorell avatar Jan 19 '23 22:01 danielmorell

This was fixed in #577.

danielmorell avatar Jan 19 '23 22:01 danielmorell