rollbar-php
rollbar-php copied to clipboard
rollbar
Telemetry support
Similar to telemetry in rollbar.js.
This needs to include the config options for enabling/disabling telemetry and scrubbing telemetry data.
So, guys, how are you going to pass telemetry to backend when exception occurs? Do you have a plan how to achieve this?
I'm really interested about this feature!
Our application is logging messages using PSR\Log level info with associated context, those informations could be very useful when debugging.
I'm using monolog.
@armetiz I probably did not understand you, but you need a new parameter to use rollbar.js. Maybe you tell me more and I will make changes?
@Yozhef this issue is not related to rollbar.js.
Telemetry is a rollbar feature to help debugging error.
When a backend error occurred, what's happening before the error could be really helpful ! This is why Telemetry is used for: display events before error.
As I said. Like many PHP Developper, i'm using monolog to record log: debug, info, warning ... Telemetry could be used to display recorded logs !
It could be a killer feature ;)
@armetiz If I correct you understand you say about this Rollbarjs-telemetry. And you need to add to config new params enabling/disabling telemetry?
@Yozhef I'm not talking about rollbarjs.
Telemetry allows you to view a 'breadcrumb' of events leading up to an exception.
Telemetry is currently available in the Javascript and iOS SDKs.
This PR is about supporting PHP.
Note:
- PSR-3: Logger Interface. https://www.php-fig.org/psr/psr-3/
- https://github.com/Seldaek/monolog
@armetiz I understand you this change you need on rollbar-php repo. I didn't understand what I need to add to config. On rollbar-php add telemetry feature?
I don't know "how" it have to be done. I don't know Rollbar API.
Usage example :
- Psr\Log\LoggerInterface::info('something useful happened', ['foo' => 'bar'])
- Psr\Log\LoggerInterface::debug('something useless happened')
- Psr\Log\LoggerInterface::error('system crashed !', ['exception' => $exception])
The error log is reported within a Rollbar occurrence. The info log is used for telemetry; because it is an event leading up to an exception. The debug log is dropped because level is too low.
As I said. I'm using monolog. See FingerCrossHandler
The Rollbar PHP SDK have to be updated to allow developers sending telemetry events using the Rollbar or RollbarLogger class.
The Rollbar PHP Documentation have to be updated to inform developers about how to send telemetry events using SDK.
I will be working on this feature shortly. It's great to see there is a lot of interest.
@armetiz 👋🏽 just reviewed this thread and will need some more context on current state; however, this sounds like a promising feature to invest in. You've been patient and I'm grateful!
Good to know @cyrusradfar !
Note that the FingerCrossHandler may not be the solution.
Note also that for Sentry it's named Breadcrumbs.
Hi @armetiz I am the new maintainer of this SDK. I am still working on putting together a roadmap with our product team. We understand the value of telemetry support and appreciate how patient you have been! Once we have a roadmap for this, I will try to make sure to reply to this thread with more details.
After some internal conversation we determined that there needs to be some cleanup work that should happen before we add telemetry support. Unfortunately, the cleanup requires breaking changes e.g. #570.
We want to make sure the changes are working and stable before adding a large new feature like telemetry support. Because of that we are shifting telemetry back from v4.0 to v4.1.
We appreciate everyone's patience!
Hi there.
I don't want to be sarcastic, but .. come on, it's been a while!
I can see that #570 will be solved. Telemetry is an important feature to debug error.
Do you plan to work on it this quarter?
Regards
Sorry for the late response! We do plan on working on telemetry this quarter.
Ok. So, I am not good at setting goals. Sorry for the delay! Thank you for your patience.
However, the PR is now created and awaiting review. Please feel free to check it out and provide any feedback, questions, or concerns you have on the PR here #634.
you’ll be the first developer to ever misestimate. It’s great that you’re pushing and holding yourself accountable. thanks for driving this Daniel.
On Fri, Feb 16, 2024 at 4:09 PM Daniel Morell @.***> wrote:
Ok. So, I am not good at setting goals. Sorry for the delay! Thank you for your patience.
However, the PR is now created and awaiting review. Please feel free to check it out and provide any feedback, questions, or concerns you have on the PR here #634 https://github.com/rollbar/rollbar-php/pull/634.
— Reply to this email directly, view it on GitHub https://github.com/rollbar/rollbar-php/issues/349#issuecomment-1949510328, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABASCWDMYSMRK4C5BRMIQO3YT7YLHAVCNFSM4E4IS4D2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJUHE2TCMBTGI4A . You are receiving this because you were mentioned.Message ID: @.***>
-- This message is intended only for the individual or entity to which it is addressed. It may contain privileged, confidential information which is exempt from disclosure under applicable laws. If you are not the intended recipient, you are strictly prohibited from disseminating or distributing this information (other than to the intended recipient) or copying this information. If you have received this communication in error, please notify us immediately by e-mail or by telephone at the above number. Thank you.
Telemetry is now available via v4.1.0-beta. We would appreciate anyone who is willing to test it and provide feedback.