karma-systemjs fix: useBundles option is not respected and was set incorrectly for systemjs

fix: useBundles option is not respected and was set incorrectly for systemjs

Open AdamWillden opened this issue 7 years ago • 10 comments

The method for setting bundles changed May 2015 here (tagged [email protected]): https://github.com/systemjs/systemjs/commit/2141c64b31f2b4b35f9089c2f306049d334c652e

Closes #91, #90

Feb 06 '17 18:02 AdamWillden

I assume you're not targeting systemjs @ < 0.17

Feb 06 '17 18:02 AdamWillden

I should say I have no way of running the plugin to properly test it... as I'm using another plugin which depends upon this. I assume you know of way to test this yourself @rolaveric?

Feb 06 '17 18:02 AdamWillden

This fix works for me with: [email protected] [email protected]

Feb 08 '17 14:02 jcestibariz

Thanks @jcestibariz :-)

I've since realised that multiple calls to System.config are okay so the code could be simplified a bit so that rather than modifying karma.config.systemjs.config we could just call System.config({ bundles: [] }); afterwards.

Feb 08 '17 15:02 AdamWillden

@AdamWillden: Sounds good, if you make the changes I can test again.

Feb 09 '17 00:02 jcestibariz

@AdamWillden, @jamesbrobb actually looks like #85 (which was included in r0.16.0) is causing both this problem and #86.

I also went back to r0.15.0 and I don't see this problem anymore.

I think the fix for both is to rollback that change. The solution for the problem in #85 is just to specify an empty bundles array in the karma.systemjs configuration to override the bundles in the systemjs configuration.

Feb 10 '17 16:02 jcestibariz

Any update on when this fix will be merged and released? Looks like this bug is causing SystemJs to break with versions 0.17 and above.