twitch-indicator icon indicating copy to clipboard operation
twitch-indicator copied to clipboard

Terzag patch 1

Open terzag opened this issue 7 years ago • 0 comments

(It's the first time I try to publish code on GIT, sorry if I do it wrong, I have basically no idea what I'm doing.)

A few changes to fit twitch-indicator to my needs:

  1. Added the game played in the menu entry next to the channel name. Haven't added it in the nofication, might be a good idea.

  2. Added the channel icon in the menu (it's easier to check the online channels with a quick look that way IMO). For this, I moved the code that fetches the picture to fetch_live_streams() and updated def_add_streams_menu() and push_notifications(). Not sure it's the best way to do this, as I'm not really −or even at all− a Python developer and made the changes by tweaking what I understood from the code until it worked.

  3. Changed the way the icon is handled: removed the DE check to use the colored twitch.png icon bundled with the indicator instead. Displaying an icon depending on the DE is not a good idea, as it presupposes that the user will use some specific themes. E.g. the Ubuntu icon is light, which works fine with the default Ambiant theme and its dark toolbar but doesn't fit the Radiance theme (the other official theme installed with Ubuntu) and its light toolbar. In the same way, the icon for MATE is dark. While it matches (I guess) the default MATE theme for most of the distros, it doesn't for Ubuntu MATE, which use themes similar to Ubuntu with dark and light toolbars. It's better to use a generic color icon (that fits the hicolor theme, independant of the DEs) and let the icon themes creators include their own icon that fits the design and overrides the indicator.

terzag avatar Sep 12 '17 20:09 terzag