Rok Mandeljc

Results 553 comments of Rok Mandeljc

> This issue still persists in PyInstaller 4.5.1 with file produced by an old version. What is "an old version" here? And does PyInstaller 3.6 under Python 3 open that...

> /var/folders/24/lznsq7bs3jqd0t03v7n1wc0c0000gq/T/_MEIh4TmLO/python: /var/folders/24/lznsq7bs3jqd0t03v7n1wc0c0000gq/T/_MEIh4TmLO/python: cannot execute binary file This one is because macOS filesystem is case-insensitive, and there's `Python` shared library located in the `_MEIPASS`. And [`PyQt5` rthook explicitly prepends `PATH`...

Adding equivalent of `is_win` condition to the referenced code block should probably do the trick, as `PATH` does not influence shared library search on linux and macOS.

What version of `PyQt5` are you using in your environment? Does `fix-4859-macos-subprocess-open ` branch fix the problem with test cases you reported in https://github.com/pyinstaller/pyinstaller/issues/4859#issuecomment-811046377?

>However, since I have read in several places that shell=True has some security concerns. Could Someone give insights regarding that? This is an issue tracker for PyInstaller, not a general...

> However we might also be able to add validation to the parameters for `--add-data` which give a more useful error. (eg, pass in something ending with `.py`/`.pyw`/`.spec` and error...

> Then I'd say I'm slightly more in favour of making both `;` and `:` separators on all platforms Having `:` as a separator on Windows will require extra care...

But on the other hand, I guess if we can make both colon and semi-colon universal, that might be less of a hassle for users, because they can mix them...

The extra entries for generated `Info.plist` can already be specified in the .spec file, by passing `info_plist` dict to the `BUNDLE`. So `CFBundleShortVersionString` can be passed either via that dict,...