Rok Mandeljc

Results 553 comments of Rok Mandeljc

Then how about this: ```python import webbrowser import os lp_key = "LD_LIBRARY_PATH" print(f"lp: {os.environ.get(lp_key)}") lp_orig = os.environ.get(f"{lp_key}_ORIG") print(f"lp_orig: {lp_orig}") if lp_orig is not None: os.environ[lp_key] = lp_orig else: del os.environ[lp_key]...

> Should it be specific to webbrowser? Wouldn't it make sense to apply this to any `subprocess.Popen()` whose executable is not vendored (i.e. not in the `sys._MEIPASS` folder)? That way...

> Setting `os.environ["LD_LIBRARY_PATH"]` has no effect on the current process once the executable is running right? In which case why not just change it back to the original globally after...

> Whilst we're there, it might be good to try and set the defaults for `stdout`, `stderr` and `stdin` to `DEVNULL` in windowed mode. But how will the people learn...

> > For example, on Windows, we cannot have MyCamelCaseModule.py and mycamecasemodule.py on filesystem > > Can't we? If they were in different directories which are both in `sys.path` then...

Approach b) implicitly assumes that subtraction is targeting DATA and BINARY entries by default, which I suppose might be seen as reasonable, considering only `DATA`, `BINARY`, `EXTENSION`, and `OPTION` are...

> Ughh, this feels like a problem we shouldn't have landed in in the first place. Yeah, it's something that we've inherited, along with the docs that encourage subtraction without...

Sounds good. I'm planning on deprecating the `TOC` and remove its use from our codebase sooner or later.

So long-term, there's no point to this PR and what it attempts to fix.

Yeah, `onefile` builds are broken for both `PySide2` and `PyQt5+PyQtWebEngine` and judging by the comments in our tests, this has been a case for a while. The crash is due...