spellcheck-github-actions icon indicating copy to clipboard operation
spellcheck-github-actions copied to clipboard

Investigate possibility of suppressing HTML tags in output

Open jonasbn opened this issue 4 years ago • 5 comments

Hi @edumco

Thanks for the elaborate feedback. I have compiled your comments to this list:

  • [ ] Investigate possibility to suppress HTML output from PySpelling

Originally posted by @jonasbn in https://github.com/rojopolis/spellcheck-github-actions/pull/12#issuecomment-636716234

jonasbn avatar Jun 04 '20 20:06 jonasbn

There is not currently a way to silence a specific filter's context (which is what the HTML tag info is). Currently, each filter just appends context for each block it returns. It is possible that a feature request could be made over on PySpelling to allow for this to be controlled on each filter if desired. If you are working directly off an HTML file, it can be useful, but I agree it is less useful when we are talking about a Markdown file that is transformed in the pipe and then handed over to the HTML filter.

facelessuser avatar Jun 04 '20 21:06 facelessuser

Hi @facelessuser

I am leaning towards dismissing this issue under wont fix, but would you agree that reporting the issue with PySpelling would be a good idea?

jonasbn avatar Jun 05 '20 09:06 jonasbn

If you would like me to follow up with it, that'd be the place. If you don't really care, then probably not :slightly_smiling_face: .

facelessuser avatar Jun 05 '20 12:06 facelessuser

By the comments I believe this issue should be closed. Right?

edumco avatar Mar 25 '21 16:03 edumco

I actually do HTML suppression, when running locally, I will see if I can move this into the action in a non-intrusive implementation, so let's keep this open a bit

jonasbn avatar Mar 28 '21 11:03 jonasbn