rojo icon indicating copy to clipboard operation
rojo copied to clipboard

Published 20 hours ago • verified publisher icon rojo-rbx

Use history recording and don't do anything permanent

Open boatbomber opened this issue 9 months ago • 3 comments

Adopts the latest ChangeHistoryService APIs. Our Undo/Redo notification warnings (to prevent accidentally undoing a Rojo patch) still work fine with this new API.

Avoids the permanent Destroy action, uses Remove instead. This closes #914.

boatbomber avatar May 14 '24 02:05 boatbomber

not much we can do about it, but I'm still unhappy

Sums up a lot of Rojo work, doesn't it 😭

boatbomber avatar May 14 '24 15:05 boatbomber

Does the problem in the linked issue only occur for changed class names? We destroy instances for normal removals, too

kennethloeffler avatar May 14 '24 18:05 kennethloeffler

Good catch, Ken. Updated all uses of Destroy to be Parent = nil, and updated all the relevant tests to pin this behavior.

boatbomber avatar May 16 '24 06:05 boatbomber