rojo icon indicating copy to clipboard operation
rojo copied to clipboard

Merge instances from the filesystem and project?

Open LPGhatguy opened this issue 5 years ago • 3 comments

Given this node from a project:

"ReplicatedStorage": {
    "$className": "ReplicatedStorage",
    "$path": "src/ReplicatedStorage",
    "$ignoreUnknownInstances": true,

    "Subfolder": {
        "$path": "src/ReplicatedStorage/Subfolder",
        "$ignoreUnknownInstances": true
    }
}

If src/ReplicatedStorage/Subfolder exists on the filesystem, Rojo will currently create two instances called Subfolder and cause all sorts of weird havoc in Roblox.

Instead, Rojo should probably merge the two instances. This would let users overwrite properties on deeply-nested instances specified on-disk!

LPGhatguy avatar Apr 30 '19 01:04 LPGhatguy

This should be fixed by init.meta.json and friends instead.

LPGhatguy avatar Jun 12 '19 23:06 LPGhatguy

This is a blocker for me, but implementation is pretty complicated FMPOV.

  • It needs to merge the instances...
  • ...while also preserving their metadata
  • ...and not locking properties like $ignoreUnknownInstances on the entire child but only for those in the scope of the partition(?)

Kampfkarren avatar Jun 19 '19 20:06 Kampfkarren

Suggested on Discord: only merge Instances if they're both folders. Otherwise, blow up?

Kampfkarren avatar Jan 12 '20 08:01 Kampfkarren