rbx-dom icon indicating copy to clipboard operation
rbx-dom copied to clipboard

Support for async writer and reader

Open cassanof opened this issue 2 years ago • 4 comments
trafficstars

Hello, it would be nice to get support for AsyncWrite and AsyncRead, either from Tokio or futures to serialize/deserialize rbxl binary and xml blobs. I would be happy to do implement it if it's not a problem.

cassanof avatar Jul 28 '23 05:07 cassanof

Hi Federico,

I think rbx_xml and rbx_binary crate features for async reads/writes would be great to have. If you're able, can you describe your use case? This will help justify the addition, and also satisfy my own curiosity 😄

kennethloeffler avatar Jul 28 '23 19:07 kennethloeffler

Hey Kenneth! Sorry, I would like to go into detail but I cannot. Abstractly, it would empower systems that rely on parsing rbx files asynchronously, without blocking.

cassanof avatar Jul 28 '23 19:07 cassanof

We're preparing for a new release soon, so it's unlikely that this will make it in before then but I would love to support this. If you want to implement it, feel free but otherwise either me or Ken will get to it soon enough!

Dekkonot avatar Jul 28 '23 21:07 Dekkonot

Nice! SGTM. I'll way for the new release :)

cassanof avatar Jul 29 '23 21:07 cassanof