Deomid Ryabkov comments

Results 363 comments of


                                            Deomid Ryabkov

feat(esp_hw_support): Add esp_mbedtls_random() (IDFGH-14979)

closing in favor of https://github.com/espressif/esp-idf/pull/15679

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

thanks for the review @kapilkedawat , comments addressed: > mbedtls funtions should be defined in mbedtls component ok, updated https://github.com/espressif/esp-idf/pull/15678 - moved to `mbedtls/esp_random.h` and renamed to `mbedtls_esp_random`. > we...

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

> Sorry, missed this PR, generally looks good, gave some comments.. We can remove second commit. thanks for the review! but i think you're confused - i pinged https://github.com/espressif/esp-idf/pull/15678, let's...

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

> #15678 won't be needed if we implement suggested changes here, right? oh, i get it, you didn't mean get rid of a commit on this MR but or the...

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

@kapilkedawat ok, i rebased the branch and fixed an inadvertent earlier rebase issue related to `struct ec`. pre-commit checks are now passing. i still don't see a point of keeping...

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

ping @kapilkedawat ?

change(wpa_supplicant): Replace use of mbedtls_ctr_drbg with esp_mbedtls_random() (IDFGH-14978)

@kapilkedawat any update?

wpa_supplicant: Do not include eap_fast_pac.c (IDFGH-14977)

@kapilkedawat should it at least be dropped from [srcs](https://github.com/espressif/esp-idf/blob/a3864c088dafb0b8ce94dba272685b850b46c837/components/wpa_supplicant/CMakeLists.txt#L62) for now?

(G)ATT transactions shall be queued by host

And, I should add, responses should be assigned properly. Right now it is possible to send two GATT reads but responses can get mixed up - when processing a response,...

porting/npl/linux: Implement ble_hs_locked_by_cur_task()

it's been a while. ping?