redis-session-store icon indicating copy to clipboard operation
redis-session-store copied to clipboard

sessions returned as Hash.with_indifferent_access?

Open toldani opened this issue 9 years ago • 2 comments

I forked this repo to add .with_indifferent_access to the hash that the session returned. It was causing issues with some of our previously-written code, but this seemed to fix it:

https://github.com/toldani/redis-session-store

toldani avatar Jun 27 '16 15:06 toldani

@toldani Hey, thanks for letting us know. Given that Hash#with_indifferent_access isn't part of the ruby stdlib, I assume you're depending on the one that comes with ActiveSupport. This gem doesn't currently depend on ActiveSupport, and I think that adding it as a runtime dependency should be carefully considered. Altering your patch to conditionally invoke Hash#with_indifferent_access would be a reasonable compromise, imho :smile_cat: Please open a pull request if you like!

meatballhat avatar Jul 02 '16 12:07 meatballhat

@toldani @meatballhat It seems this Issue has been fixed by #102.

olleolleolle avatar Jun 01 '22 06:06 olleolleolle