Julien

Results 872 comments of Julien

This is not safe. Instead we should try to reply ourselves when there is an OPTIONS query. It would mean moving CORS config into the toolkit.

I will try to detail what I have in mind if it's not clear.

This is about the HTTP client that sends the traces to the collector, not the HTTP client that we want to trace. E.g. our roundtripper can read passwords from files,...

I think this is not a good fix. The fix should be to read the file once and not making exceptions for pipes etc .

This has been resolved, the LTS does not push to the latest tag anymore.

Sounds good to me, but what would be the effect if someone uses this routinely? Would it still create non overlapping aligned blocks or would that create new blocks every...

cc @galexrt are you still willing to work on this, rebase this pull request and put the functions behind a feature flag? Thanks!

You can look at the engine ops EnableNegativeOffset which used to be a feature flag

I think a proper error saying that the feature needs to be enabled if the feature flag is not set would be better. However, I don't know if we can...