Julien comments

Results 872 comments of


                                            Julien

Persist alert 'keep_firing_for' state across restarts

Hello, I agree that keep firing for should be kept across restarts. I would accept a pull request addressing this.

Promethues counter decreases by 1 for some time series data

Indeed 20ms come from two different Prometheis servers. It looks like a configuration issue on the Thanos side. In your last comment you have a typo: promethues_replica , is it...

protocol error: received DATA after END_STREAM

Looking around it might be a regression in go1.22 net/http2. Could you try the upgrade again with `enable_http2: false` in the remote write configuration?

doc: Documentation issue in 'kernel/services/data_passing/mailboxes'

Prometheus compiles to wasm already but does not work as we do nothing for mmap.

fix(discovery): make discovery manager notify consumers of dropped targets for still defined jobs

Thanks a lot for picking up this!

Update Go module directive to v2

I am open to the change, but indeed it will cause breakages downstream that will need to update their imports.

Update Go module directive to v2

Technically, the solution we have now follows the Go documentation to the letter - [https://go.dev/doc/modules/version-numbers](https://go.dev/doc/modules/version-numbers) and [https://go.dev/doc/modules/release-workflow](https://go.dev/doc/modules/release-workflow). I think it's great, but this is the first time our solution is...

Julien

Persist alert 'keep_firing_for' state across restarts

Promethues counter decreases by 1 for some time series data

protocol error: received DATA after END_STREAM

doc: Documentation issue in 'kernel/services/data_passing/mailboxes'

fix(discovery): make discovery manager notify consumers of dropped targets for still defined jobs

Update Go module directive to v2

Update Go module directive to v2

Add funcbench logs to Github comment

Add streaming remote read to ReadClient

Add streaming remote read to ReadClient