Julien

Results 872 comments of Julien

Note: I have used this in 2.17 release and it is a really nice helper.

We miss the commits that are on the master branch between the release branch creation and the release branch merge back, like this commit in red: ![bump](https://user-images.githubusercontent.com/291750/92499913-bccfa980-f1fc-11ea-956c-50f43ae2a0b8.png)

I think we could use that for more than local testing. You could add a flag to disable pulling instead ?

Also the crossbuild image could be a .promu.yml thing. We could build prometheus with circleci-golang:1.16-node image.

Note: Not sure if goreleaser can split the build - release pattern

Here is what I mean with relabeling: ``` static_configs: - targets: [prometheus-pr, prometheus-release] relabel_configs: - source_labels: [__address__] target_label: __pprof_prefix__ replacement: /10543/$1/ - source_labels: [__address__] target_label: instance - target_label: __address__ replacement:...

I originally wanted to scrape both the PR and RELEASE pprofs within one scrape job, which is challenging since they share the same domain.

In prometheus we use readyStorage for this, in the main cmd/prometheus package. We also open the tcp socket early and do a first read of the configuration early after the...