Julien

Results 872 comments of Julien

Thank you. How could we improve the PR template to make DCO easier to grasp? DCO is mandated to us by CNCF, it is not a choice of Prometheus itself:...

You are correct, we should allow OPTIONS without basic auth, I will move this to the exporter-toolkit repository. We probably do not want this by default, but as an option...

I guess we will also need to understand how Prometheus itself handles OPTIONS requests (without basic auth).

``` curl -s -X OPTIONS https://node.demo.do.prometheus.io/metrics |head # HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles. # TYPE go_gc_duration_seconds summary go_gc_duration_seconds{quantile="0"} 4.141e-05 go_gc_duration_seconds{quantile="0.25"} 5.7685e-05 go_gc_duration_seconds{quantile="0.5"} 6.1472e-05...

For those usecases you can use https://github.com/RobustPerception/PushProx

Sorry if that is your feeling. This page contains exporters that follow our best practices. We always carefully review and comment about the exporters that are added to that page....

To remove go 1.13, we would need to see with client_golang. Otherwise, I'd suggest that you go get this commit in your fork so we can assess of the feature...

It sounds like we might need to change the tls config in kingpin flags to be a struct and add a flag for this, then pass it to ListenAndServe and...